Skip to content

chore(key-wallet-ffi): remove wallet_create_managed_wallet #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xdustinface merged 1 commit into from
May 5, 2026
Merged

chore(key-wallet-ffi): remove wallet_create_managed_wallet #710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 2 additions & 19 deletions key-wallet-ffi/FFI_API.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ This document provides a comprehensive reference for all FFI (Foreign Function I

**Auto-generated**: This documentation is automatically generated from the source code. Do not edit manually.

**Total Functions**: 259
**Total Functions**: 258

## Table of Contents

Expand Down Expand Up @@ -69,7 +69,7 @@ Functions: 19

### Wallet Operations

Functions: 64
Functions: 63

| Function | Description | Module |
|----------|-------------|--------|
Expand Down Expand Up @@ -115,7 +115,6 @@ Functions: 64
| `wallet_create_from_mnemonic_with_options` | Create a new wallet from mnemonic with options # Safety - `mnemonic` must... | wallet |
| `wallet_create_from_seed` | Create a new wallet from seed (backward compatibility) # Safety - `seed`... | wallet |
| `wallet_create_from_seed_with_options` | Create a new wallet from seed with options # Safety - `seed` must be a... | wallet |
| `wallet_create_managed_wallet` | Create a managed wallet from a regular wallet This creates a... | transaction_checking |
| `wallet_create_random` | Create a new random wallet (backward compatibility) # Safety - `error`... | wallet |
| `wallet_create_random_with_options` | Create a new random wallet with options # Safety - `account_options` must... | wallet |
| `wallet_derive_extended_private_key` | Derive extended private key at a specific path Returns an opaque... | keys |
Expand Down Expand Up @@ -1396,22 +1395,6 @@ Create a new wallet from seed with options # Safety - `seed` must be a valid p

---

#### `wallet_create_managed_wallet`

```c
wallet_create_managed_wallet(wallet: *const FFIWallet, error: *mut FFIError,) -> *mut FFIManagedWalletInfo
```

**Description:**
Create a managed wallet from a regular wallet This creates a ManagedWalletInfo instance from a Wallet, which includes address pools and transaction checking capabilities. # Safety - `wallet` must be a valid pointer to an FFIWallet - `error` must be a valid pointer to an FFIError - The returned pointer must be freed with `managed_wallet_info_free` (or `ffi_managed_wallet_free` for compatibility)

**Safety:**
- `wallet` must be a valid pointer to an FFIWallet - `error` must be a valid pointer to an FFIError - The returned pointer must be freed with `managed_wallet_info_free` (or `ffi_managed_wallet_free` for compatibility)

**Module:** `transaction_checking`

---

#### `wallet_create_random`

```c
Expand Down
22 changes: 1 addition & 21 deletions key-wallet-ffi/src/transaction_checking.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ use crate::managed_wallet::{managed_wallet_info_free, FFIManagedWalletInfo};
use crate::types::{
transaction_context_from_ffi, FFIBlockInfo, FFITransactionContextType, FFIWallet,
};
use crate::{check_ptr, deref_ptr, deref_ptr_mut, unwrap_or_return};
use crate::{check_ptr, deref_ptr_mut, unwrap_or_return};
use dashcore::consensus::Decodable;
use dashcore::Transaction;
use key_wallet::transaction_checking::{
Expand Down Expand Up @@ -63,26 +63,6 @@ pub struct FFITransactionCheckResult {
pub affected_accounts_count: c_uint,
}

/// Create a managed wallet from a regular wallet
///
/// This creates a ManagedWalletInfo instance from a Wallet, which includes
/// address pools and transaction checking capabilities.
///
/// # Safety
///
/// - `wallet` must be a valid pointer to an FFIWallet
/// - `error` must be a valid pointer to an FFIError
/// - The returned pointer must be freed with `managed_wallet_info_free` (or `ffi_managed_wallet_free` for compatibility)
#[no_mangle]
pub unsafe extern "C" fn wallet_create_managed_wallet(
wallet: *const FFIWallet,
error: *mut FFIError,
) -> *mut FFIManagedWalletInfo {
let wallet = deref_ptr!(wallet, error);
let managed_info = ManagedWalletInfo::from_wallet(wallet.inner(), 0);
Box::into_raw(Box::new(FFIManagedWalletInfo::new(managed_info)))
}

/// Check if a transaction belongs to the wallet
///
/// This function checks a transaction against all relevant account types in the wallet
Expand Down
Loading