Some Cython fixes for WorkerState
#4321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need an integer to pass to `WorkerState` so set this to `0` instead of `None`.
As Cython may not type things based on outer scope variables when using a generator, convert the generator to a `list` comprehension, which does respect the type of external variables used within the loop. This should fix some attribute access errors seen here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to PR ( #4294 )
Noticed a couple of issues. Assigning
Noneto a typed variable. Generator expressions in Cython not respecting the type of iterated variables. This makes a couple of tweaks to fix those.