Skip to content

Some Cython fixes for WorkerState #4321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrocklin merged 2 commits into from
Dec 5, 2020
Merged

Some Cython fixes for WorkerState #4321

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dece13
Use `0` for `memory_limit` instead of `None`
jakirkham Dec 5, 2020
db8aef5
Use `list` comprehension to bind `WorkerState`
jakirkham Dec 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions distributed/scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1888,7 +1888,7 @@ async def add_worker(
now=None,
resources=None,
host_info=None,
memory_limit=None,
memory_limit=0,
metrics=None,
pid=0,
services=None,
Expand Down Expand Up @@ -3555,10 +3555,10 @@ async def replicate(
del_worker_tasks[ws].add(ts)

await asyncio.gather(
*(
*[
self._delete_worker_data(ws._address, [t.key for t in tasks])
for ws, tasks in del_worker_tasks.items()
)
]
)

# Copy not-yet-filled data
Expand Down Expand Up @@ -5536,8 +5536,10 @@ def profile_to_figure(state):
tasks_timings=tasks_timings,
address=self.address,
nworkers=len(self.workers),
threads=sum(ws._nthreads for ws in self.workers.values()),
memory=format_bytes(sum(ws._memory_limit for ws in self.workers.values())),
threads=sum([ws._nthreads for ws in self.workers.values()]),
memory=format_bytes(
sum([ws._memory_limit for ws in self.workers.values()])
),
code=code,
dask_version=dask.__version__,
distributed_version=distributed.__version__,
Expand Down