[DNM] Lower connect timeout only for local test execution

[fjetter]

Not entirely sure if this is connected to our stability issues but I don't see a reason why we would want to lower the connect timeout other than decreasing test runtimes. On CI I'm not too worried about a few seconds more runtime considering this should increase test robustness.

Tests which are actively relying on this timeout to expire (e.g. dead workers are part of the test) should specifically lower this and make their intention clear.

I'm also open to removing this entirely but I could see the point of having smaller timeouts when running locally.

[fjetter]

Interesting, the failure rate increased dramatically

[crusaderky]

What's even the benefit of reducing the timeout locally? Shouldn't we just remove the whole thing?

[crusaderky]

Interesting, the failure rate increased dramatically

Sounds like they may be all tests that expect the connection to fail before the gen_test 30s timeout expires. I think they should be all reviewed. Actually, I would like to set the connection timeout to 240s temporarily and see if more tests start falling over or become unreasonably slow to complete.

[fjetter]

What's even the benefit of reducing the timeout locally? Shouldn't we just remove the whole thing?

If anything it's about having faster tests. However, I do dislike this approach quite a bit and think that tests should be selective with this. Most tests should not care at all and those who do should be explicit

Sounds like they may be all tests that expect the connection to fail before the gen_test 30s timeout expires. I think they should be all reviewed. Actually, I would like to set the connection timeout to 240s temporarily and see if more tests start falling over or become unreasonably slow to complete.

I'll push a commit and we'll see 👀

[github-actions]

Unit Test Results

       12 files  ±    0         12 suites  ±0   7h 48m 24s ⏱️ + 41m 52s
  2 620 tests ±    0    2 527 ✔️  -   13    80 💤 ±  0  13 ❌ +13 
14 906 runs   - 738  14 036 ✔️  - 745  823 💤  - 40  47 ❌ +47 

For more details on these failures, see this check.

Results for commit c69bff1. ± Comparison against base commit fb8484e.

♻️ This comment has been updated with latest results.