Remove connect timeout in test #5902
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjetter
commented
Mar 4, 2022
Comment on lines
239
to
246
| def reset_config(): | ||
| warnings.warn( | ||
| "This methods will be removed soon. Consider using the contextmanager " | ||
| "distributed.utils_test.clean_config instead", | ||
| DeprecationWarning, | ||
| ) | ||
| dask.config.config.clear() | ||
| dask.config.config.update(copy.deepcopy(original_config)) |
Member
Author
There was a problem hiding this comment.
I consider this to be an anti-pattern and would suggest to remove this. utils_test is kind of a public API so we'll need to go through a deprecation cycle.
Member
Author
|
Wow, way too many failures for this change. I'll need to have a look |
Contributor
Unit Test Results 12 files ±0 12 suites ±0 7h 32m 17s ⏱️ + 31m 36s For more details on these failures and errors, see this check. Results for commit 3367f31. ± Comparison against base commit 39c5e88. ♻️ This comment has been updated with latest results. |
crusaderky
approved these changes
Mar 5, 2022
| warnings.warn( | ||
| "This methods will be removed soon. Consider using the contextmanager " | ||
| "distributed.utils_test.clean_config instead", | ||
| DeprecationWarning, |
Collaborator
There was a problem hiding this comment.
Suggested change
| DeprecationWarning, | |
| FutureWarning, |
fjetter
force-pushed
the
remove_connect_timeout_in_test
branch
from
ad0f293 to
3367f31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm still poking at #5791 but I don't see a reason to postpone the removal of the 5s timeout.
What makes this line even worse is that it a global setting. The set is not used in a contextmanager so this leaks through to all tests, even those that are not using the
cleanfixture assuming it was once called in the interpreter.To avoid having these kind of config leaks, I introduced a contextmanager that properly restores the original state once left and installed it as an autouse fixture.
IMO, the entire
cleanshould be an autouse but I want to keep changes small for nowcc @graingert @crusaderky