Use ensure_bytes from dask.utils
#6295
Conversation
Also drop `ensure_bytes` implementation & tests from Distributed.
jakirkham
force-pushed
the
use_dask_ensure_bytes
branch
from
cadb0bf to
3cf1b23
Compare
|
This will likely fail until PR ( dask/dask#9050 ) is merged. |
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @jakirkham. I left one comment about going through a quick deprecation cycle, but overall this looks good to me
Keep `ensure_bytes` around and have it call the `dask.utils` implementation. Though have it raise a `DeprecationWarning` so users know this will be going away in the future and should update their code.
| warnings.warn( | ||
| "`distributed.utils.ensure_bytes` is deprecated. " | ||
| "Please switch to `dask.utils.ensure_bytes`. " | ||
| "This will be removed in `2022.6.0`.", | ||
| DeprecationWarning, | ||
| stacklevel=2, | ||
| ) |
There was a problem hiding this comment.
Please let me know if this looks alright.
Also picked 2022.6.0 as the point when we would remove this. Though that is somewhat arbitrary. Happy to change if needed.
|
Thanks James! 😄 Should be ready for another look 🙂 |
Unit Test Results 16 files ± 0 1 errors 15 suites ±0 7h 16m 9s ⏱️ + 5m 42s For more details on these parsing errors and failures, see this check. Results for commit 69d1f44. ± Comparison against base commit 52b6920. |
|
@jrbourbeau any more thoughts on this? 🙂 |
|
Thanks James! 😄 |
2 participants
Depends on PR ( dask/dask#9050 )
Drops internal
ensure_bytesimplementation in favor Dask's implementation. Thus getting rid of some code duplication that we've been carrying around.pre-commit run --all-files