-
-
Notifications
You must be signed in to change notification settings - Fork 748
Improve exception catching in UCX communication #7132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @wence- |
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 6h 51m 25s ⏱️ + 21m 25s Results for commit 61e5af0. ± Comparison against base commit 37fd8b5. ♻️ This comment has been updated with latest results. |
|
Lints fails are addressed by #7131 |
wence-
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor typo, but otherwise looks good, thanks!
|
I think if you merge trunk (or rebase) the linting errors will disappear |
|
The test_shutdown_localcluster failure is a known flaky tests: The test_sni failure is also unrelated but I've not seen it before. I'm going to restart CI but it would be good to keep an eye on it: |
This seems like the kind of test that is very likely to fail on heavily loaded virtualised systems. |
|
All tests pass now -- merging in. @wence- if you have thoughts on improving either of the flaky tests they would be extremely appreciated |
Closes #7130
As was previously discussed in #6996, some of the exception catching could be improved for both read and write tasks which are now addressed by the changes contained here.
pre-commit run --all-files