Update typing for system_monitor after python/typeshed#8829 #7131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We must now explicitly no-op cast to sdiskio before accessing properties of the disk_io_counters call. This is safe because initialisation logic ensures that we never reach these branches except in the "not None" case.
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 6h 57m 21s ⏱️ + 16m 5s Results for commit 6bc6c44. ± Comparison against base commit 07e2259. |
wence-
commented
Oct 10, 2022
2 tasks
Co-authored-by: Lawrence Mitchell <wence@gmx.li>
crusaderky
reviewed
Oct 11, 2022
crusaderky
approved these changes
Oct 11, 2022
Collaborator
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We must now explicitly no-op cast to sdiskio before accessing properties of the disk_io_counters call. This is safe because initialisation logic ensures that we never reach these branches except in the "not None" case.
pre-commit run --all-filescc @crusaderky.