Skip to content

Conversation

@crusaderky
Copy link
Contributor

@crusaderky crusaderky commented Oct 3, 2022

On diskless hosts, psutil.disk_io_counters() can return None:
https://github.com/giampaolo/psutil/blob/3cd1a6d14c96bd83434cb6240cc7a35f995af0ab/psutil/__init__.py#L2064-L2066

Also, both disk_io_counters() and net_io_counters() change return type to dict if you pass perdisk=True and pernic=True respectively.

@crusaderky crusaderky changed the title psutil.get_io_counters() can return None psutil.get_io_counters() and get_io_counters() Oct 3, 2022
@crusaderky crusaderky changed the title psutil.get_io_counters() and get_io_counters() psutil.disk_io_counters() and net_io_counters() Oct 3, 2022
@github-actions

This comment has been minimized.

2 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2022

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@JelleZijlstra JelleZijlstra merged commit 6414250 into python:master Oct 3, 2022
@crusaderky crusaderky deleted the disk_io_counters branch October 3, 2022 16:35
wence- added a commit to wence-/distributed that referenced this pull request Oct 10, 2022
We must now explicitly no-op cast to sdiskio before accessing
properties of the disk_io_counters call. This is safe because
initialisation logic ensures that we never reach these branches except
in the "not None" case.
crusaderky pushed a commit to dask/distributed that referenced this pull request Oct 11, 2022
wip-sync pushed a commit to NetBSD/pkgsrc-wip that referenced this pull request Oct 22, 2022
2022.10.0

Released on October 14, 2022
Enhancements
    Use of new dask CLI (GH#6735) Doug Davis
    Refactor occupancy (GH#7075) Hendrik Makait
    Expose managed/unmanaged/spilled memory to Prometheus (GH#7112) crusaderky
    Round up saturation-factor (GH#7116) Gabe Joseph
    Return default on KeyError at any level in get_metadata (GH#7109) Hendrik Makait
    Count task states per task prefix and expose to Prometheus (GH#7088) Nat Tabris
    Add scheduler-sni option for dask workers (GH#6290) Burt Holzman
Bug Fixes
    Improve exception catching in UCX communication (GH#7132) Peter Andreas Entschev
    Improve robustness of PipInstall plugin (GH#7111) Hendrik Makait
Maintenance
    Fix dependencies that should point to dask/dask (GH#7138) James Bourbeau
    Hold on to z.sum() until test completes (GH#7136) Lawrence Mitchell
    Bump peter-evans/create-pull-request from 3 to 4 (GH#7120)
    Update typing for system_monitor after python/typeshed#8829 (GH#7131) Lawrence Mitchell
    Fix two potentially flaky queuing tests (GH#7124) Gabe Joseph
    Bump EnricoMi/publish-unit-test-result-action from 1 to 2 (GH#7121)
    Bump actions/checkout from 2 to 3.1.0 (GH#7119)
    Revamp SystemMonitor (GH#7097) crusaderky
    Bump actions/cache from 2 to 3 (GH#7118)
    Bump actions/upload-artifact from 2 to 3 (GH#7117)
    Move dependabot configuration file (GH#7115) James Bourbeau
    Enable dependabot for GitHub Actions (GH#7101) Florian Jetter
    Update coverage upload action (GH#7100) Florian Jetter
    Adjust hardware benchmarks bokeh test (GH#7096) Florian Jetter
    Multi-platform mypy checks (GH#7094) crusaderky
    Update gpuCI RAPIDS_VER to 22.12 (GH#7084)

2022.9.2
Released on September 30, 2022
Enhancements
    Smarter stealing with dependencies (GH#7024) Hendrik Makait
    Enable Active Memory Manager by default (GH#7042) crusaderky
    Allow timeout strings in distributed.wait (GH#7081) James Bourbeau
    Make AMM memory measure configurable (GH#7062) crusaderky
    AMM support for actors (GH#7072) crusaderky
    Expose message-bytes-limit in config (GH#7074) Hendrik Makait
    Detect mismatching Python version in scheduler (GH#7018) Hendrik Makait
    Improve KilledWorker message users see (GH#7043) James Bourbeau
    Support for cgroups v2 and respect soft limits (GH#7051) Samantha Hughes
Bug Fixes
    Catch BaseException on UCX read error (GH#6996) Peter Andreas Entschev
    Fix transfer limiting in _select_keys_for_gather (GH#7071) Hendrik Makait
    Parse worker-saturation if a string (GH#7064) Gabe Joseph
    Nanny(config=...) parameter overlays global dask config (GH#7069) crusaderky
    Ensure default clients don’t propagate to subprocesses (GH#7028) Florian Jetter
Documentation
    Improve documentation of message-bytes-limit (GH#7077) Hendrik Makait
    Minor tweaks to Sphinx documentation (GH#7041) crusaderky
    Improve upload_file API documentation (GH#7040) Florian Jetter
Maintenance
    test_serialize_numba: Workaround issue with np.empty_like in NP 1.23 (GH#7089) Graham Markall
    Type platform constants for mypy (GH#7091) jakirkham
    dask-worker-space (GH#7054) crusaderky
    Remove failing test case (GH#7087) Hendrik Makait
    test_default_client (GH#7058) crusaderky
    Fix pre-commit fails with recent versions of mypy and pandas (GH#7068) crusaderky
    Add factorization utility (GH#7048) James Bourbeau
gjoseph92 pushed a commit to gjoseph92/distributed that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants