-
-
Notifications
You must be signed in to change notification settings - Fork 748
Add Client.unregister_scheduler_plugin method
#7968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch? Admins can comment |
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 20 files ± 0 20 suites ±0 10h 50m 6s ⏱️ - 1m 22s For more details on these failures, see this check. Results for commit 8ece1b7. ± Comparison against base commit a47cb0a. This pull request removes 7 and adds 21 tests. Note that renamed tests count towards both.This pull request removes 1 skipped test and adds 1 skipped test. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
hendrikmakait
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bphillips-exos, thanks for creating this pull request! The code generally looks good to me, I have a few suggestions regarding the tests.
|
Thanks @hendrikmakait for the suggestions! I've moved the tests into the suggested file |
hendrikmakait
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @bphillips-exos, and congratulations on your first contribution!
Closes #7958
pre-commit run --all-files