Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jul 5, 2023

Closes #7958

  • Tests added / passed
  • Passes pre-commit run --all-files

@ghost ghost requested a review from fjetter as a code owner July 5, 2023 14:37
@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       20 files  ±       0         20 suites  ±0   10h 50m 6s ⏱️ - 1m 22s
  3 718 tests +     14    3 609 ✔️ +     17     106 💤 ±  0  3  - 3 
35 962 runs  +1 155  34 209 ✔️ +1 104  1 748 💤 +52  5  - 1 

For more details on these failures, see this check.

Results for commit 8ece1b7. ± Comparison against base commit a47cb0a.

This pull request removes 7 and adds 21 tests. Note that renamed tests count towards both.
distributed.shuffle.tests.test_shuffle_extension
distributed.shuffle.tests.test_shuffle_extension ‑ test_installation_on_scheduler
distributed.shuffle.tests.test_shuffle_extension ‑ test_installation_on_worker
distributed.shuffle.tests.test_shuffle_extension ‑ test_split_by_partition
distributed.shuffle.tests.test_shuffle_extension ‑ test_split_by_worker
distributed.shuffle.tests.test_shuffle_extension ‑ test_split_by_worker_empty
distributed.shuffle.tests.test_shuffle_extension ‑ test_split_by_worker_many_workers
distributed.diagnostics.tests.test_progress ‑ test_multiprogress_cancel
distributed.diagnostics.tests.test_progress ‑ test_multiprogress_warns
distributed.diagnostics.tests.test_progress ‑ test_multiprogress_with_prefix
distributed.diagnostics.tests.test_progress ‑ test_multiprogress_with_spans
distributed.diagnostics.tests.test_progressbar ‑ test_progress_function_raises
distributed.diagnostics.tests.test_progressbar ‑ test_progress_function_warns
distributed.diagnostics.tests.test_scheduler_plugin ‑ test_unregister_scheduler_plugin
distributed.diagnostics.tests.test_scheduler_plugin ‑ test_unregister_scheduler_plugin_from_client
distributed.diagnostics.tests.test_widgets ‑ test_multibar_func_warns
distributed.diagnostics.tests.test_widgets ‑ test_multibar_with_spans
…
This pull request removes 1 skipped test and adds 1 skipped test. Note that renamed tests count towards both.
distributed.shuffle.tests.test_shuffle_extension
distributed.shuffle.tests.test_shuffle_plugins

♻️ This comment has been updated with latest results.

@hendrikmakait hendrikmakait self-requested a review July 13, 2023 18:02
Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bphillips-exos, thanks for creating this pull request! The code generally looks good to me, I have a few suggestions regarding the tests.

@ghost
Copy link
Author

ghost commented Jul 17, 2023

Thanks @hendrikmakait for the suggestions! I've moved the tests into the suggested file

Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bphillips-exos, and congratulations on your first contribution!

@hendrikmakait hendrikmakait merged commit 7b0aca7 into dask:main Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add unregister_scheduler_plugin method to Scheduler and Client

2 participants