Fix staticcheck warning (QF1001) and update .gitignore for PR #520 #523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds command and API endpoint to initialize a newly created wallet with the ActorID on chain. Once a wallet is created with `singularity wallet create` and it's been sent Fil or DataCap, run `singularity wallet init <address>` to run a lookup and update it's ActorID field.
Adds the ability to update name, location, and contact fields for wallets. Fields like address, actor ID, balances, and type may not be updated.
Allows creating wallets of SPWallet type from create handler. This will validate the provided Address and ActorID to prevent errors. Also allows inserting optional details like name, contact info, and location on creation rather than requiring a separate update.
Sankara-Jefferson
pushed a commit
that referenced
this pull request
Jun 26, 2025
- Adds ability to create wallet with optional details: `singularity wallet create --name "my wallet"` - Adds ability to create SP wallet: `singularity wallet create --address f12345 --actor-id f0123` - Handles all edge cases if parameters are not correct - Validates addresses and actor ID - Adds ability to modify details of any wallet: `singularity wallet update --name "new name" --location "somewhere else" --contact "their@email.com"` - Adds ability to update wallet after initialization: `singularity wallet init f12345` Relies on #517 The lint error is addressed by PR #523.
Contributor
Author
|
Issue resolved by this |
Collaborator
|
Can you explain why that PR fixed the issue? It doesn't seem like you changed the relevant code in that PR, only how we run staticcheck. |
parkan
pushed a commit
that referenced
this pull request
Oct 22, 2025
- Adds ability to create wallet with optional details: `singularity wallet create --name "my wallet"` - Adds ability to create SP wallet: `singularity wallet create --address f12345 --actor-id f0123` - Handles all edge cases if parameters are not correct - Validates addresses and actor ID - Adds ability to modify details of any wallet: `singularity wallet update --name "new name" --location "somewhere else" --contact "their@email.com"` - Adds ability to update wallet after initialization: `singularity wallet init f12345` Relies on #517 The lint error is addressed by PR #523.
parkan
pushed a commit
that referenced
this pull request
Nov 6, 2025
- Adds ability to create wallet with optional details: `singularity wallet create --name "my wallet"` - Adds ability to create SP wallet: `singularity wallet create --address f12345 --actor-id f0123` - Handles all edge cases if parameters are not correct - Validates addresses and actor ID - Adds ability to modify details of any wallet: `singularity wallet update --name "new name" --location "somewhere else" --contact "their@email.com"` - Adds ability to update wallet after initialization: `singularity wallet init f12345` Relies on #517 The lint error is addressed by PR #523.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the staticcheck QF1001 warning by applying De Morgan’s Law in CreateHandler.
It also updates .gitignore to exclude the singularity and singularity. binaries.
Intended as a helper PR to unblock CI in PR #520.This PR resolves the staticcheck QF1001 warning by applying De Morgan’s Law in CreateHandler.
It also updates .gitignore to exclude the singularity and singularity. binaries.
Intended as a helper PR to unblock CI in PR #520.