Skip to content

Fix staticcheck warning (QF1001) and update .gitignore for PR #520 #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Sankara-Jefferson wants to merge 6 commits into from
Closed

Fix staticcheck warning (QF1001) and update .gitignore for PR #520 #523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3b44391
chore: run linter
zachfedor Jun 12, 2025
9928cae
feat: add init wallet handler
zachfedor Jun 18, 2025
95bee38
feat: add wallet update command and endpoint
zachfedor Jun 12, 2025
52a3576
feat: add SPWallet fields to create wallet handler
zachfedor Jun 18, 2025
7dd9588
Fix staticcheck warning (QF1001) with De Morgan's Law and update .git…
Jun 26, 2025
1cc688c
Merge branch 'zach-wallet-create' into fix/staticcheck-pr-520
Sankara-Jefferson Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,3 +56,6 @@ dist/
dump_extracted.sql
dump_postgres_reordered_data_only.sql
dump_postgres_reordered_fixed.sql

singularity
singularity.
1 change: 1 addition & 0 deletions handler/wallet/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,8 @@
switch {
case !hasKeyType && !hasAddress && !hasActorID:
return nil, errors.New("must specify either KeyType (for UserWallet) or Address/ActorID (for SPWallet)")
case !hasKeyType && (!hasAddress || !hasActorID):
case !hasKeyType && !(hasAddress && hasActorID):

Check failure on line 160 in handler/wallet/create.go

View workflow job for this annotation

GitHub Actions / go-check / All 

QF1001: could apply De Morgan's law (staticcheck)

Check failure on line 160 in handler/wallet/create.go

View workflow job for this annotation

GitHub Actions / go-check / All 

QF1001: could apply De Morgan's law (staticcheck)
return nil, errors.New("must specify both Address and ActorID (for SPWallet)")
case hasKeyType && (hasAddress || hasActorID):
return nil, errors.New("cannot specify both KeyType (for UserWallet) and Address/ActorID (for SPWallet) - please specify parameters for one wallet type")
Expand Down
Loading