Align seqcli's environment override handling with Seq's#366
Merged
nblumhardt merged 3 commits intodatalust:devfrom Oct 11, 2024
Merged
Align seqcli's environment override handling with Seq's#366nblumhardt merged 3 commits intodatalust:devfrom
seqcli's environment override handling with Seq's#366nblumhardt merged 3 commits intodatalust:devfrom
Conversation
liammclennan
approved these changes
Oct 11, 2024
|
Nice one! thank you for the quick turn-around 🚀 |
This was referenced Oct 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #365
The README shows how environment variable setting overrides should work, but this was committed in error, the README updates should have gone to Seq Forwarder, which was the project that gained environment override support at that time.
Instead of fixing the README, I've lined up
seqcli's configuration handling with Seq's - this should help us along towards a fully-consistent experience across client and server in the future.SEQCLI_CONNECTION_SERVERURLnow works:Sorry about the confusing experience, @richard-stafflink - my mistake, here :-)