Fix exception when writing connection.apiKey values#369
Merged
nblumhardt merged 2 commits intodatalust:devfrom Oct 14, 2024
Merged
Fix exception when writing connection.apiKey values#369nblumhardt merged 2 commits intodatalust:devfrom
connection.apiKey values#369nblumhardt merged 2 commits intodatalust:devfrom
Conversation
…path, obsolete setting names should be allowed
liammclennan
approved these changes
Oct 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores behavior broken in #366 - the
connection.apiKeyvalue relies on user writes to the property withseqcli configgoing through theApiKeyproperty rather than the user-visibleEncodedApiKeyproperty.The behavior change led to an exception rather than exposure of any sensitive info, but this whole mechanism could do with some further hardening and test coverage.