Update phonenumberutiltest.py#242
Merged
daviddrysdale merged 2 commits intodaviddrysdale:devfrom Jun 10, 2022
Merged
Conversation
Making similar changes in other cases also.
daviddrysdale
approved these changes
Jun 10, 2022
Contributor
|
@daviddrysdale -- are you also bumping the package minimum to 2.7, or only test requirements? If the former I'm happy to prepare a PR updating to 2.7. A |
Owner
|
Thanks, but I'm not aware of anything (non-test) that would break for 2.5 & 2.6, so I don't propose to change anything. |
Contributor
No worries -- it's much easier doing no work! A |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on changes suggested in cl/451855712 by pylint