Skip to content

Update phonenumberutiltest.py #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daviddrysdale merged 2 commits into from
Jun 10, 2022
+24 −24
Merged

Update phonenumberutiltest.py #242

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37c00b2
Update phonenumberutiltest.py
penmetsaa Jun 10, 2022
3fb7cc0
Update phonenumberutiltest.py
penmetsaa Jun 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 24 additions & 24 deletions python/tests/phonenumberutiltest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ def testGetInstanceLoadUSMetadata(self):
self.assertEqual("US", metadata.id)
self.assertEqual(1, metadata.country_code)
self.assertEqual("011", metadata.international_prefix)
self.assertTrue(metadata.national_prefix is not None)
self.assertIsNotNone(metadata.national_prefix)
self.assertEqual(2, len(metadata.number_format))
self.assertEqual("(\\d{3})(\\d{3})(\\d{4})", metadata.number_format[1].pattern)
self.assertEqual("\\1 \\2 \\3", metadata.number_format[1].format)
Expand Down Expand Up @@ -324,26 +324,26 @@ def testGetExampleNumber(self):
# Should return the same response if asked for FIXED_LINE_OR_MOBILE too.
self.assertEqual(DE_NUMBER,
phonenumbers.example_number_for_type("DE", PhoneNumberType.FIXED_LINE_OR_MOBILE))
self.assertTrue(phonenumbers.example_number_for_type("US", PhoneNumberType.FIXED_LINE) is not None)
self.assertTrue(phonenumbers.example_number_for_type("US", PhoneNumberType.MOBILE) is not None)
self.assertIsNotNone(phonenumbers.example_number_for_type("US", PhoneNumberType.FIXED_LINE))
self.assertIsNotNone(phonenumbers.example_number_for_type("US", PhoneNumberType.MOBILE))
# We have data for the US, but no data for VOICEMAIL, so return null.
self.assertTrue(phonenumbers.example_number_for_type("US", PhoneNumberType.VOICEMAIL) is None)
self.assertIsNone(phonenumbers.example_number_for_type("US", PhoneNumberType.VOICEMAIL))
# CS is an invalid region, so we have no data for it.
self.assertTrue(phonenumbers.example_number_for_type("CS", PhoneNumberType.MOBILE) is None)
self.assertIsNone(phonenumbers.example_number_for_type("CS", PhoneNumberType.MOBILE))
# Python version extra test
self.assertTrue(phonenumbers.example_number_for_type("US", PhoneNumberType.UNKNOWN) is None)
self.assertIsNone(phonenumbers.example_number_for_type("US", PhoneNumberType.UNKNOWN))

# RegionCode 001 is reserved for supporting non-geographical country
# calling code. We don't support getting an example number for it with
# this method.
self.assertTrue(phonenumbers.example_number("001") is None)
self.assertIsNone(phonenumbers.example_number("001"))

def testGetInvalidExampleNumber(self):
# RegionCode 001 is reserved for supporting non-geographical country
# calling codes. We don't support getting an invalid example number
# for it with invalid_example_number.
self.assertTrue(phonenumbers.invalid_example_number("001") is None)
self.assertTrue(phonenumbers.invalid_example_number("CS") is None)
self.assertIsNone(phonenumbers.invalid_example_number("001"))
self.assertIsNone(phonenumbers.invalid_example_number("CS"))
usInvalidNumber = phonenumbers.invalid_example_number("US")
self.assertEqual(1, usInvalidNumber.country_code)
self.assertFalse(usInvalidNumber.national_number == 0)
Expand All @@ -352,18 +352,18 @@ def testGetExampleNumberForNonGeoEntity(self):
self.assertEqual(INTERNATIONAL_TOLL_FREE, phonenumbers.example_number_for_non_geo_entity(800))
self.assertEqual(UNIVERSAL_PREMIUM_RATE, phonenumbers.example_number_for_non_geo_entity(979))
# Python version extra test
self.assertTrue(phonenumbers.example_number_for_non_geo_entity(666) is None)
self.assertIsNone(phonenumbers.example_number_for_non_geo_entity(666))

def testGetExampleNumberWithoutRegion(self):
# In our test metadata we don't cover all types: in our real metadata, we do.
self.assertTrue(phonenumbers.example_number_for_type(None, PhoneNumberType.FIXED_LINE) is not None)
self.assertTrue(phonenumbers.example_number_for_type(None, PhoneNumberType.MOBILE) is not None)
self.assertTrue(phonenumbers.example_number_for_type(None, PhoneNumberType.PREMIUM_RATE) is not None)
self.assertIsNotNone(phonenumbers.example_number_for_type(None, PhoneNumberType.FIXED_LINE))
self.assertIsNotNone(phonenumbers.example_number_for_type(None, PhoneNumberType.MOBILE))
self.assertIsNotNone(phonenumbers.example_number_for_type(None, PhoneNumberType.PREMIUM_RATE))
# Python version extra test: temporarily drop SUPPORTED_REGIONS to check
# that example_number_for_type() falls back to non-geo numbers.
saved = phonenumberutil.SUPPORTED_REGIONS
phonenumberutil.SUPPORTED_REGIONS = set()
self.assertTrue(phonenumbers.example_number_for_type(None, PhoneNumberType.TOLL_FREE) is not None)
self.assertIsNotNone(phonenumbers.example_number_for_type(None, PhoneNumberType.TOLL_FREE))
phonenumberutil.SUPPORTED_REGIONS = saved

def testConvertAlphaCharactersInNumber(self):
Expand Down Expand Up @@ -1285,7 +1285,7 @@ def testGetNationalDiallingPrefixForRegion(self):
self.assertEqual(None, phonenumbers.ndd_prefix_for_region("CS", False))
# Python version extra test
# IT has no national prefix
self.assertTrue(phonenumbers.ndd_prefix_for_region("IT", False) is None)
self.assertIsNone(phonenumbers.ndd_prefix_for_region("IT", False))

def testIsNANPACountry(self):
self.assertTrue(phonenumbers.is_nanpa_country("US"))
Expand Down Expand Up @@ -2978,19 +2978,19 @@ def testIsMobileNumberPortableRegion(self):
self.assertFalse(phonenumbers.is_mobile_number_portable_region("XY"))

def testGetMetadataForRegionForNonGeoEntity_shouldBeNull(self):
self.assertTrue(PhoneMetadata.metadata_for_region("001") is None)
self.assertIsNone(PhoneMetadata.metadata_for_region("001"))

def testGetMetadataForRegionForUnknownRegion_shouldBeNull(self):
self.assertTrue(PhoneMetadata.metadata_for_region("ZZ") is None)
self.assertIsNone(PhoneMetadata.metadata_for_region("ZZ"))

def testGetMetadataForNonGeographicalRegionForGeoRegion_shouldBeNull(self):
self.assertTrue(PhoneMetadata.metadata_for_nongeo_region(country_code=1) is None)
self.assertIsNone(PhoneMetadata.metadata_for_nongeo_region(country_code=1))

def testGetMetadataForRegionForMissingMetadata(self):
self.assertTrue(PhoneMetadata.metadata_for_region("YYZ") is None)
self.assertIsNone(PhoneMetadata.metadata_for_region("YYZ"))

def testGetMetadataForNonGeographicalRegionForMissingMetadata(self):
self.assertTrue(PhoneMetadata.metadata_for_nongeo_region("800000") is None)
self.assertIsNone(PhoneMetadata.metadata_for_nongeo_region("800000"))

def testMetadataEquality(self):
# Python version extra tests for equality against other types
Expand Down Expand Up @@ -3184,7 +3184,7 @@ def testMetadataRegister(self):
self.assertRaises(Exception, PhoneMetadata, *("XY",),
**{'preferred_international_prefix': u('9999'),
'register': True})
self.assertTrue(phonenumbers.example_number_for_type('XY', PhoneNumberType.PERSONAL_NUMBER) is None)
self.assertIsNone(phonenumbers.example_number_for_type('XY', PhoneNumberType.PERSONAL_NUMBER))

def testShortMetadataRegister(self):
# Python version extra tests for short metadata registration.
Expand All @@ -3210,7 +3210,7 @@ def testShortMetadataRegister(self):
**{'preferred_international_prefix': u('9999'),
'register': True,
'short_data': True})
self.assertTrue(phonenumbers.example_number_for_type('XZ', PhoneNumberType.PERSONAL_NUMBER) is None)
self.assertIsNone(phonenumbers.example_number_for_type('XZ', PhoneNumberType.PERSONAL_NUMBER))

def testNonGeoMetadataRegister(self):
# Python version extra tests for non-geo metadata registration.
Expand Down Expand Up @@ -3280,7 +3280,7 @@ def testEnumString(self):

def testCoverage(self):
# Python version extra tests
self.assertTrue(phonenumberutil._region_code_for_number_from_list(GB_NUMBER, ("XX",)) is None)
self.assertIsNone(phonenumberutil._region_code_for_number_from_list(GB_NUMBER, ("XX",)))
self.assertEqual((0, "abcdef"),
phonenumberutil._extract_country_code("abcdef"))
metadata = PhoneMetadata.metadata_for_region("AU")
Expand Down Expand Up @@ -3311,7 +3311,7 @@ def testCoverage(self):
saved_mobile = metadata800.mobile
metadata800._mutable = True
metadata800.mobile = PhoneNumberDesc(example_number='')
self.assertTrue(phonenumbers.example_number_for_non_geo_entity(800) is not None)
self.assertIsNotNone(phonenumbers.example_number_for_non_geo_entity(800))
metadata800.mobile = saved_mobile
metadata800._mutable = False

Expand Down