DCO bot is stuck in "waiting for status reported"

[caniszczyk]

envoyproxy/envoy#3021

Any idea what's up?

[bkeepers]

Looks like #67 might have introduced a bug? cc @hiimbex

19:23:09.173Z ERROR event: isRequiredFor is not a function (id=c0269540-472b-11e8-9a34-0be6bd8fd8f7)
  TypeError: isRequiredFor is not a function
      at module.exports (/app/lib/dco.js:17:35)
      at check (/app/index.js:22:29)
      at <anonymous>
      at process._tickCallback (internal/process/next_tick.js:182:7)
  --
  event: {
    "id": "c0269540-472b-11e8-9a34-0be6bd8fd8f7",
    "event": "pull_request.synchronize",
    "repository": "envoyproxy/envoy",
    "installation": 53244
  }

[jwagantall]

Hi all,

Can someone please help me checking if something is causing this delay again?
Looks like my PR has gone stuck "waiting for status to be reported":
hyperledger-labs/private-data-objects#5

Thank you so much!
Jess

[dcmiddle]

This one was stuck and we ended up closing it and opening it as a new item to get past DCO being stuck. hyperledger-archives/sawtooth-core#1572

[dcmiddle]

another PR stuck on DCO: hyperledger-archives/sawtooth-core#1554

[JPWKU]

Hi, We are still seeing this issue. edgexfoundry/blackbox-testing#24

[hiimbex]

Sorry for the delay and thanks for your patience with this issue.

I think we resolved some of the causes of the "hanging" in #72, but for older PRs the DCO might need to be re-triggered to run on the PR. Opening new PRs to re-trigger the bot is definitely the first step. And I think for the PRs opened more than a week or two ago, future PRs should be fine.

The only PR here that doesn't fit that criterion is @JPWKU issue, which I think may have been due to the first commit having Signed-off-by: Bruce <weichou1229@gmail.com> and the rest of the commits having Signed-off-by: Bruce <bruce@angel-tech.com.tw> as well as the changing of the git user throughout the commits. Still, I wouldn't expect the bot to "hang" in this situation, so I'll be looking into it further.

[JPWKU]

Hi @hiimbex , That indeed was the issue. weichou1229 closed the old PR and resigned the commits with the same git user and resubmitting. It checked out after that. Thanks for looking into it.

[JPWKU]

@hiimbex I agree that it seemed a weird case for it to hang though.

[byron-marohn]

We are still seeing the DCO bot stuck, even on a newly uploaded PR.

hyperledger-labs/private-data-objects#11
hyperledger-labs/private-data-objects#15
hyperledger-labs/private-data-objects#17

Since none of us have the ability to override the DCO bot check, we are completely stuck and unable to merge PRs. Help would be much appreciated.

[hiimbex]

This is definitely the exact same issue @JPWKU just described, so I'd recommend that Mic Bowman (the original committer) associate his github account with those commits by editing his GitHub global configs locally and recommitting.

If this is a new contributor though, doing all of that git meddling might be confusing in which case I'd recommend just copying the changes and making a new commit once their global git config is set up.

Also you can remove DCO as a 'required' check in the settings page. But that does need to be done by someone with admin permissions.

I am looking into this issue and hope to have a solution soon, since this is obviously not our intended behavior.