Conversation
Signed-off-by: Bex Warner <bexmwarner@gmail.com>
|
If this does indeed fix #69, I'd sure be happy if this got merged. Thanks in advance! |
bkeepers
suggested changes
Jun 14, 2018
Contributor
bkeepers
left a comment
bkeepers
left a comment
There was a problem hiding this comment.
Ahhhh, I just ran into a situation similar to this the other day. The challenge is that there's an author field that represents the GitHub author, and a commit.author field that represents the git author data.
I think it'd be great to add a test case for this.
| const signoffRequired = await isRequiredFor(author.login) | ||
| let signoffRequired = true | ||
| if (author && author.login) { | ||
| signoffRequired = await isRequiredFor(author.login) |
Contributor
There was a problem hiding this comment.
Can this be simplified?
const signoffRequired = !author || await isRequiredFor(author.login)Signed-off-by: Bex Warner <bexmwarner@gmail.com>
Contributor
Author
|
Test added! |
hiimbex
added a commit
that referenced
this pull request
Jul 9, 2018
hiimbex
added a commit
that referenced
this pull request
Jul 13, 2018
Signed-off-by: Bex Warner <bexmwarner@gmail.com>
hiimbex
added a commit
that referenced
this pull request
Jul 14, 2018
Signed-off-by: Bex Warner <bexmwarner@gmail.com>
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #69 final issues and Sentry Unresolved type error issues.
So this is happening due to commits not being linked to any user, a state which is common for new GitHub accounts/users to be in.
In this state it appears the
authorfield is null and we check in DCO for theauthor.login(aka your GitHub login), so I've made the check more thorough to avoid this issue.