[engine/cli.rb] Handle nil name_padding #769
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When (mistakenly) starting foreman with a empty
Procfile, it ends up not being possible to exit this process via a TERM signal due to the following error:By adding a
.to_i, this simply allows theEngine::Cli#name_paddingmethod to default to 6, allowing the rest of the shutdown process to finish executing and exit the process gracefully.Alternatively, this could be fixed by not allowing an empty
Procfileto be valid (was actually not addressed in #620 ), which would most likely prevent this state from being feasible, but I think having this catch as well doesn't hurt anything. I will look into creating a PR to also solve for this as well.