[spec_helper.rb] Error when Procfile present #771
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a present and empty Procfile in the root directory of the project, this has the potential to cause specs in cli_spec.rb to fail in a non-obvious way, and is not simple to debug the root cause. Because of how `forked_foreman` is implemented, it doesn't included the `FakeFs` context to the subprocess, so it is pretty hard to deduce that it is running outside of that context, and that any generated `Procfile` (using `write_procfile` for example) will not be visible to the sub process. To avoid this confusion and errors that might be caused from this, this error is in place to warn the user if the file currently exists and prevents running the specs with it in place.
Owner
|
I was not able to reproduce the failure that you're guarding against. Where does the Procfile need to be to trigger the failure? |
Contributor
Author
|
Not going to lie... this is from 4 years ago and 2 jobs ago... I kinda forget the context at this point... I can maybe take a look later today. |
Contributor
Author
|
Okay, took another look at this, and I think I understand what I was trying to do at the time. However, since this is so old, I don't have any logs of what I was doing, but here is a guess at the series of a events:
But again, this is just a guess... I can try pulling this branch down and testing to see (as well doing a |
Owner
|
Thanks. I’ll take a look as well and see if I can figure out what might be going on. |
Owner
|
Got it, thanks for identifying the issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While developing specs for #770 I ran into this scenario (only a problem currently with those changes from #770 in place and a empty Procfile present).
Issue
With a present and empty
Procfilein the root directory of the project, this has the potential to cause specs incli_spec.rbto fail in a non-obvious way, and is not simple to debug the root cause.Because of how
forked_foremanis implemented, it doesn't included theFakeFscontext to the subprocess, so it is pretty hard to deduce that it is running outside of that context, and that any generatedProcfile(usingwrite_procfilefor example) will not be visible to the sub process.To avoid this confusion and errors that might be caused from this, this error is in place to warn the user if the file currently exists and prevents running the specs with it in place.