Skip to content

Bug fixes#3

Open
LukeLR wants to merge 3 commits intodecisionpatterns:devfrom
LukeLR:dev
Open

Bug fixes#3
LukeLR wants to merge 3 commits intodecisionpatterns:devfrom
LukeLR:dev

Conversation

@LukeLR
Copy link

@LukeLR LukeLR commented Oct 7, 2022

I fixed two minor bugs. First, R would crash after displaying help with this error message:

    Error in quit(save = FALSE) :
      one of "yes", "no", "ask" or "default" expected.
    Calls: opt_help -> quit
    Execution halted

This is fixed in 1c5d53d. Furthermore, missing required options with multiple flags got printed like this:

Option(s): [-p--project] is required, but was not supplied.

I fixed the output to make it more readable and standardized:

Option(s): [-p, --project] is required, but was not supplied.

Looking forward to your feedback! Thanks a lot for this awesome library, I've searched a lot for argument parsing in R, and across all the 6 libraries I checked out, this was the only one to provide a required-option which was very important to me.

LukeLR added 3 commits October 7, 2022 17:17
…s this error:

Error in quit(save = FALSE) :
  one of "yes", "no", "ask" or "default" expected.
Calls: opt_help -> quit
Execution halted
Option(s): [-p--project] is required, but was not supplied.

and now is:

Option(s): [-p, --project] is required, but was not supplied.

which makes it more readable and conforms better with established standards
@LukeLR
Copy link
Author

LukeLR commented Apr 10, 2023

@ctbrown @brownct @DarylMcCullough Maybe someone can look into this? :)

@LukeLR
Copy link
Author

LukeLR commented Jun 2, 2023

@ctbrown @brownct @DarylMcCullough Any chance this will get merged? Feel free to give feedback if anything should be improved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant