Skip to content

Bug fixes #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LukeLR wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Bug fixes #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b7e725
Ignore binary package folders under /R/ from building using install_l…
LukeLR Oct 7, 2022
1c5d53d
Fix quitting after showing help in noninteractive sessions. This fixe…
LukeLR Oct 7, 2022
141c802
Fix output of missing options with multiple flags. The output was:
LukeLR Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,5 @@ inst/doc
optigrab.Rcheck/
optigrab_*.gz


# binary packages from building using install_local()
R/*/
4 changes: 2 additions & 2 deletions R/opt_get.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ opt_get <- function(
ret <- opt_grab( flag=flag, n=n, opts=opts)


# Apply defaults, including trying to coerce to the defailts
# Apply defaults, including trying to coerce to the defaults
# class
if( ! missing(default) ) {
if( is.na(ret) )
Expand All @@ -157,7 +157,7 @@ opt_get <- function(
if( is.na(ret) && missing(default) && required == TRUE )
stop(
call. = FALSE
, "\n\tOption(s): [", flag, "] is required, but was not supplied."
, "\n\tOption(s): [", paste(flag, collapse=", "), "] is required, but was not supplied."
)


Expand Down
2 changes: 1 addition & 1 deletion R/opt_help.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ opt_help <- function( name=c('help','?'), opts=commandArgs() ) {
for( nm in names(opts) )
cat( paste(' ', nm, ":", opts[[nm]], sep=" "), sep="\n" )

if( ! interactive() ) quit( save = FALSE )
if( ! interactive() ) quit( save = "no" )

return(TRUE)

Expand Down