mixpool: Cache recently removed msgs. #3366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
mixpool_cache_recently_removed_msgs
branch
from
a4cb1a3 to
c5c898a
Compare
davecgh
force-pushed
the
mixpool_cache_recently_removed_msgs
branch
3 times, most recently
from
23bde48 to
7b2ac5e
Compare
jrick
reviewed
Jun 13, 2024
jrick
approved these changes
Jun 13, 2024
Member
jrick
left a comment
jrick
left a comment
There was a problem hiding this comment.
code-wise with the exception of the nitpick i had on the comment wording, this looks ok.
davecgh
force-pushed
the
mixpool_cache_recently_removed_msgs
branch
4 times, most recently
from
c85b955 to
2f79a9c
Compare
This adds a cache to house mix messages that have recently been removed from the mixpool. It makes use of the new container/lru module to handle automatic expiration of entries and maximum entry limiting. The rationale for this change is that it is considered misbehavior to advertise a mix message and then claim it is not found when the corresponding request arrives. Maintaining a separate cache of mix messages recently removed from the mixpool for a short period of time significantly increases the probability they are available to serve when a request for the advertisement arrives independent of the current status of the mixpool.
davecgh
force-pushed
the
mixpool_cache_recently_removed_msgs
branch
from
2f79a9c to
e1569fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #3360 and is rebased on #3362.
This adds a cache to house mix messages that have recently been removed from the mixpool. It makes use of the new
container/lrumodule to handle automatic expiration of entries and maximum entry limiting.The rationale for this change is that it is considered misbehavior to advertise a mix message and then claim it is not found when the corresponding request arrives. Maintaining a separate cache of mix messages recently removed from the mixpool for a short period of time significantly increases the probability they are available to serve when a request for the advertisement arrives independent of the current status of the mixpool.