netsync: Remove spent PRs from tip block txns. #3367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
netsync_remove_prs_from_tip_block
branch
3 times, most recently
from
87b3696 to
7e53596
Compare
jrick
approved these changes
Jun 13, 2024
davecgh
force-pushed
the
netsync_remove_prs_from_tip_block
branch
4 times, most recently
from
b32e0d3 to
49ffd40
Compare
Now that recently removed mix messages are independently cached for a short period, this reverts the change that only removed spent pair requests from previous block transactions to make it track the current best tip again. For reference, the change was originally made to avoid immediately removing mixpool messages that are still propagating the network when a block was quickly mined which includes transactions created from those very same mix messages. However, as noted when the change was made, while it was a quick way to address the stated scenario, it doesn't deal with large reorgs nicely. The new method is much more robust and works under all scenarios, so it is preferable for the mixpool to track the current tip.
davecgh
force-pushed
the
netsync_remove_prs_from_tip_block
branch
from
49ffd40 to
4b485d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #3366.
Now that recently removed mix messages are independently cached for a short period, this reverts the change that only removed spent pair requests from previous block transactions to make it track the current best tip again.
For reference, the change was originally made to avoid immediately removing mixpool messages that are still propagating the network when a block was quickly mined which includes transactions created from those very same mix messages.
However, as noted when the change was made, while it was a quick way to address the stated scenario, it doesn't deal with large reorgs nicely.
The new method is much more robust and works under all scenarios, so it is preferable for the mixpool to track the current tip.