[Deepin-Kernel-SIG] [Upstream] [linux 6.6-y] Loongarch: Sync some patches from stable

[opsiff]

stable inclusion
from mainline-v6.6.76
category: bugfix

Commit:
LoongArch: Change 8 to 14 for LOONGARCH_MAX_{BRP,WRP}
LoongArch: Fix warnings during S3 suspend

Summary by Sourcery

Increase the maximum number of hardware breakpoints and fix warnings during S3 suspend.

Bug Fixes:

• Fixed warnings during S3 suspend.

Enhancements:

• Increased the maximum number of hardware breakpoints from 8 to 14.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request backports two commits from the stable branch (mainline-v6.6.76). The first commit increases the maximum number of hardware breakpoints for LoongArch architecture. The second commit fixes warnings during S3 suspend.

Class diagram for LoongArch hardware breakpoint changes

classDiagram
    class HardwareBreakpoints {
        +LOONGARCH_MAX_BRP: int
        +LOONGARCH_MAX_WRP: int
    }
    note for HardwareBreakpoints "Changed max breakpoints from 8 to 14"

    class CSRRegisters {
        +DB0-DB13: DataBreakpointRegisters
        +IB0-IB13: InstructionBreakpointRegisters
    }
    note for CSRRegisters "Added DB8-DB13 and IB8-IB13 registers"

    class DataBreakpointRegisters {
        +ADDR: register
        +MASK: register
        +CTRL: register
        +ASID: register
    }

    class InstructionBreakpointRegisters {
        +ADDR: register
        +MASK: register
        +CTRL: register
        +ASID: register
    }

    CSRRegisters *-- DataBreakpointRegisters
    CSRRegisters *-- InstructionBreakpointRegisters

Loading

State diagram for S3 suspend fix

stateDiagram-v2
    [*] --> Running
    Running --> S3_Suspend: Suspend
    S3_Suspend --> EnableWakeupGPEs: acpi_hw_enable_all_wakeup_gpes()
    EnableWakeupGPEs --> S3_Suspended
    S3_Suspended --> Running: Resume
    note right of EnableWakeupGPEs: Fixed warning by using correct function

Loading

File-Level Changes

Change	Details	Files
Increased the maximum number of hardware breakpoints for LoongArch.	Increased LOONGARCH_MAX_{BRP,WRP} from 8 to 14. Added definitions for CSRs DB8-DB13 and IB8-IB13. Added cases for breakpoint registers 8-13 in read_wb_reg and write_wb_reg functions.	arch/loongarch/include/asm/loongarch.h arch/loongarch/kernel/hw_breakpoint.c arch/loongarch/include/asm/hw_breakpoint.h
Fixed warnings during S3 suspend.	Replaced acpi_enable_all_wakeup_gpes() with acpi_hw_enable_all_wakeup_gpes() in arch/loongarch/power/platform.c. Moved the definition of acpi_hw_enable_all_wakeup_gpes to include/acpi/acpixf.h. Removed acpi_hw_enable_all_wakeup_gpes from drivers/acpi/acpica/achware.h.	arch/loongarch/power/platform.c drivers/acpi/acpica/achware.h include/acpi/acpixf.h

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @opsiff - I've reviewed your changes - here's some feedback:

Overall Comments:

• There are duplicate declarations of acpi_hw_enable_all_wakeup_gpes in acpixf.h. Please remove the redundant declaration so only one remains to prevent any potential linker or type confusion issues.
• Ensure that the extended range for hardware breakpoints (new indices 8-13 and MAX_BRP/WRP increased to 14) is fully supported by the LoongArch hardware. Verify that any usage in dependent code or assumptions about the breakpoint count are updated accordingly.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sourcery-ai[bot]
Once this PR has been reviewed and has the lgtm label, please ask for approval from opsiff. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment