Skip to content

filter input non-ASCII char before process#6739

Merged
mohanchen merged 3 commits intodeepmodeling:developfrom
goodchong:character_bugfix
Nov 28, 2025
Merged

filter input non-ASCII char before process#6739
mohanchen merged 3 commits intodeepmodeling:developfrom
goodchong:character_bugfix

Conversation

@goodchong
Copy link
Collaborator

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #6737

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@mohanchen mohanchen added Refactor Refactor ABACUS codes Features Needed The features are indeed needed, and developers should have sophisticated knowledge labels Nov 28, 2025
@mohanchen
Copy link
Collaborator

LGTM

@mohanchen mohanchen merged commit 4bf723c into deepmodeling:develop Nov 28, 2025
14 checks passed
@goodchong goodchong deleted the character_bugfix branch December 26, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Features Needed The features are indeed needed, and developers should have sophisticated knowledge Refactor Refactor ABACUS codes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check non acsii char in input and stru file

2 participants