Fix: Resolve memory leak when using solvation model in relaxing geometry#6835
Merged
mohanchen merged 1 commit intodeepmodeling:developfrom Jan 7, 2026
Merged
Fix: Resolve memory leak when using solvation model in relaxing geometry#6835mohanchen merged 1 commit intodeepmodeling:developfrom
mohanchen merged 1 commit intodeepmodeling:developfrom
Conversation
Remove dynamically allocated array for induced_rho to prevent memory leak
Collaborator
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologies for the previous PR #6832 (comment), which mixed bug fixes and refactoring. The refactoring was performed during the investigation of a memory leak issue #6794 (comment). Now the PR #6832 (comment) was divided into fix and refactor.
The previous memory leak was caused by induced_rho not being deleted in source/source_estate/module_pot/efield.cpp.
Reminder
Linked Issue
Fix #...
Unit Tests and/or Case Tests for my changes
What's changed?
Any changes of core modules? (ignore if not applicable)