Fix model-devi with mixed_type format#2433
Merged
wanghan-iapcm merged 4 commits intodeepmodeling:develfrom May 24, 2023
Merged
Conversation
Fix model-devi with mixed_type format; Add UTs; Add detection of whether models support mixed_type inference.
for more information, see https://pre-commit.ci
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## devel #2433 +/- ##
==========================================
+ Coverage 76.61% 76.81% +0.19%
==========================================
Files 227 227
Lines 23792 23805 +13
Branches 1667 1653 -14
==========================================
+ Hits 18229 18286 +57
+ Misses 4465 4421 -44
Partials 1098 1098
☔ View full report in Codecov by Sentry. |
njzjz
reviewed
Mar 29, 2023
njzjz
reviewed
Mar 29, 2023
njzjz
requested changes
Mar 29, 2023
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Fix deepmodeling#1708. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
61 tasks
wanghan-iapcm
pushed a commit
that referenced
this pull request
Jun 26, 2023
This PR sets specific mesh shapes (7 for pbc and 1 for no pbc) for mixed type. So when an operator does not throw mixed type, it will throw errors. It will be more accurate than the implementation in #2433 to check if a model supports DPRc. `make_default_mesh` is updated and out-of-date behaviors are removed. --------- Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix model-devi with mixed_type format;
Add UTs;
Add detection of whether models support mixed_type inference.