set specific mesh shapes for mixed type#2481
Merged
wanghan-iapcm merged 6 commits intodeepmodeling:develfrom Jun 26, 2023
Merged
set specific mesh shapes for mixed type#2481wanghan-iapcm merged 6 commits intodeepmodeling:develfrom
wanghan-iapcm merged 6 commits intodeepmodeling:develfrom
Conversation
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## devel #2481 +/- ##
==========================================
- Coverage 74.38% 74.28% -0.11%
==========================================
Files 227 227
Lines 23401 23410 +9
Branches 1673 1680 +7
==========================================
- Hits 17408 17391 -17
- Misses 4896 4922 +26
Partials 1097 1097
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
iProzd
approved these changes
Jun 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets specific mesh shapes (7 for pbc and 1 for no pbc) for mixed type.
So when an operator does not throw mixed type, it will throw errors. It will be more accurate than the implementation in #2433 to check if a model supports DPRc.
make_default_meshis updated and out-of-date behaviors are removed.