fix TestDeepPotAPBCExcludeTypes#2680
Merged
wanghan-iapcm merged 1 commit intodeepmodeling:develfrom Jul 15, 2023
Merged
Conversation
I found that deepmodeling#956 broke this unit test. It only tested a normal model. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## devel #2680 +/- ##
==========================================
+ Coverage 78.36% 78.37% +0.01%
==========================================
Files 235 235
Lines 24488 24497 +9
Branches 1469 1469
==========================================
+ Hits 19189 19200 +11
+ Misses 4909 4905 -4
- Partials 390 392 +2
☔ View full report in Codecov by Sentry. |
denghuilu
approved these changes
Jul 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that #956 broke this unit test, making it only testing a standard model.