speedup model compression UTs#956
Merged
amcadmus merged 1 commit intodeepmodeling:develfrom Aug 12, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## devel #956 +/- ##
==========================================
- Coverage 75.51% 75.41% -0.11%
==========================================
Files 85 85
Lines 6796 6796
==========================================
- Hits 5132 5125 -7
- Misses 1664 1671 +7
Continue to review full report at Codecov.
|
njzjz
approved these changes
Aug 12, 2021
gzq942560379
pushed a commit
to HPC-AI-Team/deepmd-kit
that referenced
this pull request
Sep 2, 2021
njzjz
added a commit
to njzjz/deepmd-kit
that referenced
this pull request
Jul 15, 2023
I found that deepmodeling#956 broke this unit test. It only tested a normal model. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
wanghan-iapcm
pushed a commit
that referenced
this pull request
Jul 15, 2023
I found that #956 broke this unit test, making it only testing a standard model. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the benchmark on my local workstation, the model compression unit test within the
$deepmd_source_dir/source/tests/test_model_compression.pyconsumes about 50% of the total unit test execution time. The execution time oftest_model_compression.pycan be largely reduced by this PR.The main benefits of this PR are: