Samyamr/full precision for ZeRO Stage2 and Stage3#1004
Merged
Conversation
tjruwase
approved these changes
Apr 26, 2021
samyam
commented
Apr 26, 2021
This was referenced Apr 27, 2021
Collaborator
|
And just to indicate priority to this PR, we have all those bfloat16 models that won't train under fp16/mixed precision, and users want to use DeepSpeed to overcome GPU memory limitations, so they badly need this. Thank you! |
Collaborator
|
When you feel this looks good enough to test please let me know and I will start testing this branch on the |
Assert to check if param.dtype is torch.half for ZeRO3 should only happen if the model was initialized in ZeRO3 context.
jeffra
approved these changes
Apr 29, 2021
Collaborator
|
This is awesome - thank you! I encountered only one issue: As I am writing HF transformers tests for fp32, I found that I thought the whole point of passing |
3 tasks
stas00
added a commit
to stas00/DeepSpeed
that referenced
this pull request
Apr 30, 2021
I'm not sure if this is the best approach but with deepspeedai#1004 I still have to pass `zero.Init(dtype)` because this branch never gets executed: ``` def _set_dtype(self, ds_config, dtype): if ds_config is not None and dtype is None: _ds_config = DeepSpeedConfig(ds_config) self.dtype = torch.half if _ds_config.fp16_enabled else torch.float ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.