Merged
Conversation
I'm not sure if this is the best approach but with deepspeedai#1004 I still have to pass `zero.Init(dtype)` because this branch never gets executed: ``` def _set_dtype(self, ds_config, dtype): if ds_config is not None and dtype is None: _ds_config = DeepSpeedConfig(ds_config) self.dtype = torch.half if _ds_config.fp16_enabled else torch.float ```
stas00
requested review from
RezaYazdaniAminabadi,
ShadenSmith,
arashashari,
awan-10,
cli99,
conglongli,
eltonzheng,
jeffra,
minjiaz,
niumanar,
samyam and
tjruwase
as code owners
jeffra
approved these changes
Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is the best approach but with #1004 I still have to pass
zero.Init(dtype)because this branch never gets executed asdtype is never None, so the config is ignored.So with
fp16.enabled=FalseI get:AssertionError: The fp16 is not enabled but dtype on parameters not fp16