This repository was archived by the owner on Feb 11, 2025. It is now read-only.
feat(*): Enforce signatures on server#300
Merged
thomastaylor312 merged 1 commit intodeislabs:mainfrom Feb 9, 2022
Merged
Conversation
This completes the change to full enforcement of signing and verification on both client and server. This PR specifically is for the server. It will no longer accept bindles that do not have a signature. All signature rules are enforced according to the verification strategy. Please note that most of the changes in this PR were to update the tests, which was a good exercise. This is a breaking behavior change that should be well-documented at the next release. Closes deislabs#106
Closed
vdice
reviewed
Feb 4, 2022
technosophos
approved these changes
Feb 9, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This completes the change to full enforcement of signing and verification on
both client and server. This PR specifically is for the server. It will no
longer accept bindles that do not have a signature. All signature rules
are enforced according to the verification strategy. Please note that most
of the changes in this PR were to update the tests, which was a good exercise.
This is a breaking behavior change that should be well-documented at the next release.
Closes #106