PR changes for IN4189 from @eckhardtgirl, @raies1000, @wrvangeest#4
Closed
Raies1000 wants to merge 48 commits intodelftsre:masterfrom
wrvangeest:master
Closed
PR changes for IN4189 from @eckhardtgirl, @raies1000, @wrvangeest#4Raies1000 wants to merge 48 commits intodelftsre:masterfrom wrvangeest:master
Raies1000 wants to merge 48 commits intodelftsre:masterfrom
wrvangeest:master
Conversation
Exclude /bin in each module
Tests for Camera class that covers ~70% of the code. Mock class of the Bound Interface included for one test.
Not all parts tested yet
rendersubscenenode and preloadspatial need asserts
Removed the Viewport responsibilities from RenderManager and added them to new class ViewportManager. RenderManager now has ViewportManager object, that other classes can also reach to manage the Viewports.
Tests into master
render Method is refactored: three loops into one.
Refactor viewportmanager
This commit refactors computation of left, right, bottom and top plane in onFrameChange in order to avoid code duplication and improve understandability
Refactor camera
Caps.OpenGL32 is called multiple times. If one changes the version, this has to be done multiple places. By making this a variable, changes can be made more easiliy
Refactored preloadScene intro preloadNode and preLoadGeometry. This splits the functionality of preloadScene into its two functionalities
Empty render() implementations removed. render() method removed from Control Interface. TO DO: add InstancedNodeControl render to list
TO DO: Create subInterface to replace if's
Seperated method from Control Interface for those several classes that actually use it.
Refactor filterpostprocessor
Refactored rendersubscene into renderSubsceneNode and renderSubsceneGeometry
Binary input capsule
Getters and setters now tested. 100% coverage in ViewPortManager.
Refactor rendermanager
Remove render Created extra interface in order to remove empty method declarations
Raies1000
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for IN4189 on behalf of: @eckhardtgirl, @Raies1000, @wrvangeest