Skip to content

Add volume_class support to volume.py#38

Merged
shenda1 merged 1 commit intodell:mainfrom
stgaver:volume_class_37
May 21, 2025
Merged

Add volume_class support to volume.py#38
shenda1 merged 1 commit intodell:mainfrom
stgaver:volume_class_37

Conversation

@stgaver
Copy link
Copy Markdown
Contributor

@stgaver stgaver commented Apr 28, 2025

Fixes bug #37

@stgaver
Copy link
Copy Markdown
Contributor Author

stgaver commented Apr 28, 2025

@anupamaloke @sachin-apa can you help review? Thanks!

@anupamaloke
Copy link
Copy Markdown
Collaborator

@stgaver, thank you for submitting the PR. Changes look good to me and I have added this to the backlog. Could you please share some details on the testing that your performed and may be share them to us ansible.team@dell.com?

@anupamaloke anupamaloke linked an issue Apr 28, 2025 that may be closed by this pull request
@stgaver
Copy link
Copy Markdown
Contributor Author

stgaver commented Apr 28, 2025

ansible.team@dell.com

Thanks, I sent an email with the test script and results. Good thing as I had an issue in the rename method.

@stgaver
Copy link
Copy Markdown
Contributor Author

stgaver commented May 1, 2025

Do we know when this can merge? We'd like to use this internally in our automation. It's a bit hard to distribute internally since we install from PyPi as part of our requirements.txt.

@anupamaloke
Copy link
Copy Markdown
Collaborator

@stgaver, we will be prioritizing this for the next sprint. I will come back with the ETA early next week as to when we could release it on PyPi.

@anupamaloke anupamaloke added the enhancement New feature or request label May 2, 2025
@stgaver
Copy link
Copy Markdown
Contributor Author

stgaver commented May 14, 2025

Hi @anupamaloke , any update on this?

@Bhavneet-Sharma
Copy link
Copy Markdown
Collaborator

Hi @stgaver
we have started working on this pull request. Will be able to close this PR by end of this sprint.

@Bhavneet-Sharma Bhavneet-Sharma requested a review from doriac11 May 20, 2025 13:48
@shenda1 shenda1 merged commit c6b9180 into dell:main May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add volume_class support to volume APIs

5 participants