Skip to content

ENH : cleanup ICA code #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dengemann merged 1 commit into from
Dec 15, 2012
Merged

ENH : cleanup ICA code #3

dengemann merged 1 commit into from
Dec 15, 2012

Conversation

@agramfort
Copy link
Collaborator

@agramfort agramfort commented Dec 15, 2012

pardon me if you don't recognize your code...

dengemann
dengemann reviewed Dec 15, 2012
View reviewed changes
mne/preprocessing/ica.py
Copy link
Owner

@dengemann dengemann Dec 15, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very clean approach, had it in mind too but wasn't sure whether you would like it. appreciate the public attributes!

dengemann added a commit that referenced this pull request Dec 15, 2012
@dengemann
Merge pull request #3 from agramfort/ica_fix_sklearn
2733918 
ENH : cleanup ICA code --- thanks for the commits, appreciate it!
@dengemann dengemann merged commit 2733918 into dengemann:ica_fix_sklearn Dec 15, 2012
dengemann pushed a commit that referenced this pull request Jul 13, 2015
@wronk
Merge pull request #3 from Eric89GXL/sm
84703c9 
ENH: Speed up by ~5x
dengemann pushed a commit that referenced this pull request May 1, 2018
@makkostya @larsoner
[MRG+1] Add function for random parcellation (mne-tools#4955)
8ef95c9 
* Add functions to create random parcellation

* add test for random_parcellation

* add random_parcellation to python_reference

* fixe pep8

* fixe pep8 #2

* fixe pep #3

* add random_state, small corrections

* fixes random_state

* FIX: Alphabetical
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@agramfort @dengemann