Bump Ruby from 3.3.6 to 3.4.2

[JamieMagee]

What are you trying to accomplish?

Prepare for the Ruby 3.4.0 release on 25th December.

Anything you want to highlight for special attention from reviewers?

New warnings

After this upgrade there are a couple of new warnings printed in the console:

/home/jamie/.local/share/mise/installs/ruby/3.4.0-rc1/lib/ruby/gems/3.4.0+1/gems/json-2.6.3/lib/json/common.rb:3: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add ostruct to your Gemfile or gemspec to silence this warning.
/home/jamie/.local/share/mise/installs/ruby/3.4.0-rc1/lib/ruby/gems/3.4.0+1/gems/excon-0.110.0/lib/excon.rb:41: warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add logger to your Gemfile or gemspec to silence this warning.
/home/jamie/.local/share/mise/installs/ruby/3.4.0-rc1/lib/ruby/gems/3.4.0+1/gems/reline-0.5.2/lib/reline.rb:9: warning: fiddle was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add fiddle to your Gemfile or gemspec to silence this warning

• json
  • Solved in Suppress warning(Ruby 3.4) requiring fiddle from terminfo.rb ruby/reline#721
  • Released in 2.7.2
  • NOTE: The fix for fix regression in json gem by using an older version #8509 was included in 2.7.1
• excon
  • Open issue Add logger as dependency excon/excon#860
• reline
  • Solved in Suppress warning(Ruby 3.4) requiring fiddle from terminfo.rb ruby/reline#721
  • Released in 0.5.9

Removing require "set"

After updating the target rubocop ruby version from 3.1 to 3.4 I was able to remove require "set", as the set module has been loaded by default since Ruby 3.2.0¹.

Set is now available as a builtin class without the need for require "set"

Updating ruby/ruby-setup

Support for Ruby 3.4.0-rc1 was only added in ruby/ruby-setup@1.204.0: ruby/setup-ruby#675

Adding require "ostruct"

See #11163

RFC3986 URI parser is now the default

Previously, the RFC2396 was the default, but it was changed to RFC3896². We were using the ABS_URI regex, but the make_regex with RFC3896 has equivalent behaviour.

The RFC3986 parser also throws a slightly different error message for InvalidURIError.

irb(main):001> "https://example.com".match?(URI::RFC2396_PARSER.regexp[:ABS_URI])
=> true
irb(main):002> "//example.com".match?(URI::RFC2396_PARSER.regexp[:ABS_URI])
=> false
irb(main):003> "example.com".match?(URI::RFC2396_PARSER.regexp[:ABS_URI])
=> false
irb(main):012> "https://example.com".match?(URI::RFC3986_PARSER.make_regexp)
=> true
irb(main):013> "//example.com".match?(URI::RFC3986_PARSER.make_regexp)
=> false
irb(main):014> "example.com".match?(URI::RFC3986_PARSER.make_regexp)
=> false

How will you know you've accomplished your goal?

All tests pass

Checklist

• I have run the complete test suite to ensure all tests and linters pass.
• I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
• I have written clear and descriptive commit messages.
• I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
• I have ensured that the code is well-documented and easy to understand.

Footnotes

1. https://www.ruby-lang.org/en/news/2022/12/25/ruby-3-2-0-released/ ↩

2. https://github.com/ruby/uri/pull/107 ↩

[JamieMagee]

Not 100% sure why URI::RFC_3986.make_regexp.match?(dependency_url) doesn't give the same results for this specific instance. But using RFC2396_PARSER explicitly works for now.

[deivid-rodriguez]

This is great!

[deivid-rodriguez]

There's already 1.18.0.rc1 which already supports platform specific versions in Ruby 3.4. I suspect final version will be released very soon.

[JamieMagee]

Okay, let me upgrade to 1.18.0.rc1 for now, then we can bump to 1.18.0 once it's released.

EDIT: It's not worth the hassle. Just going to leave it as-is for now.

[deivid-rodriguez]

Cool, it should work the same, just take longer to install.

[deivid-rodriguez]

/home/jamie/.local/share/mise/installs/ruby/3.4.0-rc1/lib/ruby/gems/3.4.0+1/gems/json-2.6.3/lib/json/common.rb:3: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add ostruct to your Gemfile or gemspec to silence this warning.
/home/jamie/.local/share/mise/installs/ruby/3.4.0-rc1/lib/ruby/gems/3.4.0+1/gems/excon-0.110.0/lib/excon.rb:41: warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add logger to your Gemfile or gemspec to silence this warning.
/home/jamie/.local/share/mise/installs/ruby/3.4.0-rc1/lib/ruby/gems/3.4.0+1/gems/reline-0.5.2/lib/reline.rb:9: warning: fiddle was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add fiddle to your Gemfile or gemspec to silence this warning

@JamieMagee Did you find warning locations all messed up or is it just me? I'm trying to get Ruby print the code locations that I was expecting at ruby/ruby#12412.

[JamieMagee]

@JamieMagee Did you find warning locations all messed up or is it just me? I'm trying to get Ruby print the code locations that I was expecting at ruby/ruby#12412.

I didn't actually check the exact locations. The gem name was enough for me to investigate.

[jeffwidman]

Dec 25th 🎄 has come and gone, want to update now that 3.4.0 is out of release candidate?

[JamieMagee]

@jeffwidman I'm still on vacation. I can tackle this when I'm back, or feel free to update it before then.

I wanted to do the hard work while I had some free time before the holidays. The final step should be very simple.

[landongrindheim]

I think we'll want to go straight to Ruby 3.4.1

[edouard]

Can you merge this so we can use dependabot on projects requiring ruby 3.4?

[JamieMagee]

Updated to Ruby 3.4.1. The smoke test failures appear unrelated, as all other PRs are failing on the same tests.

[nickjer]

Hoping this can be merged soon as dependabot has been failing for weeks now on a project with Ruby 3.4 requirements.

[nickjer]

Looks like this now can be updated to Ruby 3.4.2.

[JamieMagee]

I've reabsed this on top of Ruby 3.4.2. There are a couple of test failures that still need to be addressed before merge, but not many.

[schinery]

Any news on this getting resolved/merged?

[JamieMagee]

@schinery I'm closing this in favour of #11681. @chrisyuska is very close to getting it merged.