Suppress warning(Ruby 3.4) requiring fiddle from terminfo.rb #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
approved these changes
Jun 10, 2024
ima1zumi
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make CI green
Reline (ansi, terminfo) tries to load fiddle and terminfo. Reline behaves better with fiddle but does not necessarily requires fiddle.
Fiddle is planned to be a bundled gem in Ruby 3.5. In Ruby 3.4,
require 'fiddle'through bundle exec will warnThis pull request suppress that warning causing test failure.
lib/reline/io/windows.rbfully depends on fiddle, and we may need to think addding fiddle to gemspec dependency before 3.5, but it is out of scope of this pull request.