-
Notifications
You must be signed in to change notification settings - Fork 108
PoS Add P2P vote and timeout messages #555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tholonious
merged 14 commits into
feature/pos-messaging-schema
from
sa/add-p2p-msgs-for-votes-and-timeouts
Jun 25, 2023
Merged
PoS Add P2P vote and timeout messages #555
tholonious
merged 14 commits into
feature/pos-messaging-schema
from
sa/add-p2p-msgs-for-votes-and-timeouts
Jun 25, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
AeonSw4n
approved these changes
Jun 16, 2023
Contributor
AeonSw4n
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
lazynina
requested changes
Jun 21, 2023
lazynina
approved these changes
Jun 23, 2023
Member
lazynina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two nits on comments - otherwise looks good!
This was referenced Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Reference schema: https://github.com/deso-protocol/hotstuff_pseudocode/blob/afd4337e8aaad1be56b12c6173e4f82d79b362e0/fast_hotstuff_bls.go