PoS Implement Bitset data structure #564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 21, 2023
Contributor
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
lazynina
approved these changes
Jun 21, 2023
Member
lazynina
left a comment
lazynina
left a comment
There was a problem hiding this comment.
functionality looks good - just some comment clean up
tholonious
force-pushed
the
sa/update-block-header-to-support-pos-schema
branch
from
0ce5751 to
d798c71
Compare
tholonious
force-pushed
the
sa/implement-bitset-data-structure
branch
from
3e87ccd to
07a9535
Compare
AeonSw4n
approved these changes
Jun 26, 2023
Contributor
AeonSw4n
left a comment
AeonSw4n
left a comment
There was a problem hiding this comment.
Nice and simple, I like it! And we're 💯 we won't fall victim to treacherous implementation details concealed in third-party libraries. I'm giving approval since I'm convinced the code works. Though I've left some comments around encode/decode. Could you address these before merging?
tholonious
force-pushed
the
sa/implement-bitset-data-structure
branch
2 times, most recently
from
c6da9fb to
4d6f3ba
Compare
Base automatically changed from
sa/update-block-header-to-support-pos-schema
to
feature/pos-messaging-schema
June 27, 2023 15:56
tholonious
force-pushed
the
sa/implement-bitset-data-structure
branch
from
4d6f3ba to
a3e0fa9
Compare
This was referenced Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.