PoS Block Producer: Txn Timestamps in MsgDeSoBlock #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 2, 2023
Merged
Merged
Contributor
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Oct 2, 2023
tholonious
suggested changes
Oct 3, 2023
Contributor
tholonious
left a comment
tholonious
left a comment
There was a problem hiding this comment.
The new RevolutionMetadata as a whole is unused until work on the revolution mechanic is started. Without a full spec for the mechanic, the new metadata type may not account for everything we need to include in the block. There's no rush to build it now.
Please shelf this PR and to revert to the original TransactionsConnectStatus field, since it's what we need for now. Once the spec for the new mechanic is fully ready, we can easily introduce a more full fledged revolution metadata for MsgDeSoBlock later.
Contributor
Author
|
Possible naming: Simulated Transaction Timestamps |
AeonSw4n
force-pushed
the
p/better-read-uvarint
branch
from
8e71448 to
ac0a04d
Compare
AeonSw4n
force-pushed
the
p/pos-mempool-txn-timestamp-in-block
branch
from
9ff111c to
609b8f1
Compare
This reverts commit d2c5ce2d95cfe722640b3ce14e11a9e3c042bbc8.
AeonSw4n
force-pushed
the
p/better-read-uvarint
branch
from
ac0a04d to
f520218
Compare
AeonSw4n
force-pushed
the
p/pos-mempool-txn-timestamp-in-block
branch
from
609b8f1 to
fb24a79
Compare
This was referenced Oct 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.