Diamondhands review gofmt #745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 24, 2023
Merged
Merged
Contributor
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Oct 24, 2023
Merged
… p/diamondhands-review-gofmt
AeonSw4n
added a commit
that referenced
this pull request
Oct 26, 2023
* dummy commit * ln/add-transactor-as-affected-pub-key (#675) * ln/add-transactor-as-affected-pub-key * address DH feedback --------- Co-authored-by: Lazy Nina <> * PoS Block Producer: TxnConnectStatusByIndex (#672) * TransactionConnectStatus and ConnectFailingTransaction * Revert "Merge branch 'p/bmf-status-connected' into p/failing-transactions" This reverts commit d3e543c4c3e6f03cc74087b05c268d4449ba1689, reversing changes made to 960001c. * Revert "Revert "Merge branch 'p/bmf-status-connected' into p/failing-transactions"" This reverts commit 10a147654c5147c28ec674d0650bb54c8d9cebce. * Revert "Merge branch 'p/bmf-status-connected' into p/failing-transactions" This reverts commit d3e543c4c3e6f03cc74087b05c268d4449ba1689, reversing changes made to a9f7827. * TransactionConnectStatus and ConnectFailingTransaction * Initial _connectFailingTransaction * ConnectFailingTransaction and GlobalParamsEntry updates * Fix merge conflicts * gofmt * Fix merge conflicts * Fix blockheight * Fix merge conflicts * gofmt * Revert connect failing transaction * Add TxnStatusConnectedIndex to block and header * Fix naming * Fix tests; remove asserts * Update comment * TransactionConnectStatus and ConnectFailingTransaction * Revert "Merge branch 'p/bmf-status-connected' into p/failing-transactions" This reverts commit d3e543c4c3e6f03cc74087b05c268d4449ba1689, reversing changes made to 960001c. * Revert "Revert "Merge branch 'p/bmf-status-connected' into p/failing-transactions"" This reverts commit 10a147654c5147c28ec674d0650bb54c8d9cebce. * Revert "Merge branch 'p/bmf-status-connected' into p/failing-transactions" This reverts commit d3e543c4c3e6f03cc74087b05c268d4449ba1689, reversing changes made to a9f7827. * TransactionConnectStatus and ConnectFailingTransaction * Initial _connectFailingTransaction * ConnectFailingTransaction and GlobalParamsEntry updates * Fix merge conflicts * gofmt * Fix merge conflicts * Fix merge conflicts * gofmt * Revert connect failing transaction * Add TxnStatusConnectedIndex to block and header * PoS Block Producer: _connectFailingTransaction (#673) * Revert "Revert connect failing transaction" This reverts commit e801101. * Revert * Tests * Lazy review * Simplify failing transaction fee math; add reused nonce validation * Review * PoS Block Producer: Mempool replace with higher fee (#676) * Add replace by higher fee feature to mempool * Add PKID and update map in NonceTracker * Fix nonce tracker on update global params; add more bulletproof tests * Change NonceTracker to use PublicKey * PoS Block Producer: Add Refresh Operation To PosMempool (#700) * Add Refresh; small test improvement * Rename receiver * Actually rename receiver * Remove block producer stuff * Fix Mempool interface * Fix test * PoS Block Producer: Safer ReadUvarint (#701) * Add Refresh; small test improvement * Rename receiver * Actually rename receiver * Remove block producer stuff * Fix Mempool interface * Fix test * Add RevolutionMetadata; Update varint encoding * Remove RevolutionMetadata * PoS Block Producer: MempoolTransaction Type (#703) * Revert "Remove Block Producer" This reverts commit 2f9fe64b34130f65a3a68f23835295c04d0444b7. * Add MempoolTransaction with timestamp * Remove BlockProducer * Fix tests * Simplify test * oops * PoS Block Producer: Data Structure (#704) * Revert "Remove Block Producer" This reverts commit 2f9fe64b34130f65a3a68f23835295c04d0444b7. * Add MempoolTransaction with timestamp * Remove BlockProducer * Fix tests * Simplify test * oops * Revert "Remove BlockProducer" This reverts commit 1c8bc9ded9838b33463b979b126ec519453cde4b. * Block producer code * Initial tests for block producer * More tests for block producer * Better comments and test * Move proposerRandomSeedHash to function signatures * Merge * Diamondhands review (#744) * Diamondhands review gofmt (#745) * Diamondhands review * gofmt * another gofmt * DH Pos Block Producer review (#754) --------- Co-authored-by: Lazy Nina <81658138+lazynina@users.noreply.github.com> Co-authored-by: iamsofonias <sofonias@deso.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.