Skip to content

Dont send content-type when body is FormData#37

Merged
developit merged 4 commits intodevelopit:masterfrom
fabricionaweb:master
Jul 15, 2020
Merged

Dont send content-type when body is FormData#37
developit merged 4 commits intodevelopit:masterfrom
fabricionaweb:master

Conversation

@fabricionaweb
Copy link
Copy Markdown
Contributor

@fabricionaweb fabricionaweb commented Jun 8, 2020

The browser has the ability to treat the content-type when you're omitting them for a formData content, to a file upload for instance (and it's my case)

As discussed in #28 follow my contribution :)

Im actually using the provide PR's solution in a side-project and so far worked like a charm

@googlebot
Copy link
Copy Markdown
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@fabricionaweb
Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@googlebot
Copy link
Copy Markdown
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@developit developit merged commit 962ed16 into developit:master Jul 15, 2020
@developit
Copy link
Copy Markdown
Owner

Thanks for the great PR @fabricionaweb! I swapped out the instanceof check for duck typing to save some bytes, but everything else is on master and will be released today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants