Skip to content

Dont send content-type when body is FormData #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
developit merged 4 commits into from
Jul 15, 2020
Merged

Dont send content-type when body is FormData #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0ea6b3f
Dont send content-type when body is FormData
fabricionaweb Jun 6, 2020
ae803d5
Specs for treat body as formData
fabricionaweb Jun 8, 2020
538af87
Merge branch 'master' into master
fabricionaweb Jun 22, 2020
962ed16
Merge branch 'master' into master
developit Jul 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ export default (function create(/** @type {Options} */ defaults) {
*/
const customHeaders = {};

if (data && typeof data === 'object') {
if (data && typeof data === 'object' && !(data instanceof FormData)) {
data = JSON.stringify(data);
customHeaders['Content-Type'] = 'application/json';
}
Expand Down
17 changes: 17 additions & 0 deletions test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,4 +116,21 @@ describe('redaxios', () => {
expect(res.status).toEqual(200);
expect(JSON.parse(res.data)).toEqual({ hello: 'world' });
});

it('should not send content-type when data contains FormData', async () => {
const oldFetch = window.fetch;
try {
window.fetch = jasmine.createSpy('fetch').and.returnValue(Promise.resolve());
axios.post('/foo', new FormData());
expect(window.fetch).toHaveBeenCalledTimes(1);
expect(window.fetch).not.toHaveBeenCalledWith('/foo', jasmine.objectContaining({
headers: {
'content-type': 'application/json'
}
}));
}
finally {
window.fetch = oldFetch;
}
});
});