Closed
Conversation
vincentsarago
requested review from
alukach and
emileten
and removed request for
emileten
emileten
reviewed
Sep 7, 2023
| @@ -1,18 +1,18 @@ | |||
| { | |||
| "name": "cdk-pgstac", | |||
Contributor
There was a problem hiding this comment.
this still had cdk-pgstac instead of eoapi-cdk in it ? 😵💫
Member
Author
There was a problem hiding this comment.
oh it's interesting, I pushed my own package-lock.json while it seems that when doing a release only the version number was changed in the package-lock.json, not the whole file was update 🤷♂️
Contributor
|
FYI I'll be addressing this as part of #74 -- I'll close here once the latter is merged. |
Member
Author
|
done in #74 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #68
To Be discussed: should this be considered as a breaking change? @alukach @sharkinsspatial @emileten