feat: custom runtimes, optional VPC, python 3.11#74
Merged
Conversation
…rfile for all apps BREAKING CHANGE: clients need to provide aws_lambda.AssetCode to configure their apps. Solely the python application and the requirements.txt file is not supported anymore.
8950777 to
eb20644
Compare
vincentsarago
approved these changes
Oct 5, 2023
Member
There was a problem hiding this comment.
This looks good to me.
We should make sure to document this part to explain how basic dockerfile should look
# IMPORTANT: Use the same version of python for the asset building and lambda deployment
FROM public.ecr.aws/lambda/python:3.10
WORKDIR /tmp
RUN python -m pip install pip -U
# Install application dependency
COPY runtime/requirements.txt requirements.txt
RUN python -m pip install -r requirements.txt "mangum>=0.14,<0.15" -t /asset
# Copy handler and custom code
COPY runtime/src/*.py /asset/
Member
|
@emileten We should also consider adding dockerignore file with |
a79fd3c to
a53adef
Compare
a53adef to
385ab1b
Compare
…s. Allow the user to provide anything and let the CDK method raise error and overwrite values defined within our construct. Make this clear in the documentation
Contributor
Author
|
I addressed comments ; I'll see if I can fit that into eoAPI and after confirming it works I'll fix conflicts and merge. |
Contributor
Author
|
@vincentsarago FYI in the meanwhile (this took me forever 🙄) I did these changes (I updated the description):
This is tested in deployment and good to go, about to merge! |
vincentsarago
approved these changes
Oct 31, 2023
95676ef to
d59c936
Compare
BREAKING CHANGE: * database and bootstrapper constructs merged to make the bootstrapper runtime configurable * switched to `Function` for all Lambda deployments to allow for flexibility
d59c936 to
d4859f6
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
# [6.0.0](v5.4.1...v6.0.0) (2023-10-31) ### Features * custom runtimes, optional VPC, python 3.11 ([#74](#74)) ([ba6bf09](ba6bf09)) ### BREAKING CHANGES * the `bootstrapper` construct was deleted and is no longer available. In addition, we switched from `PythonFunction` to `Function` for all lambdas.
This was referenced Nov 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A large PR with several breaking changes.
databaseandbootstrapperinto a single construct to avoid JSII issues. With this, all apps have their runtime configurable.FunctionandfromDockerBuildfor lambda functions, because the state ofPythonFunctionmakes it very hard to add flexible configurability. Now, users can override any of the lambdaFunctionparameters they want ( code, but also memory, time out...).made VPC optional for lambdas
harmonized pgstac to 0.7.10 in default runtimes.
harmonized python to 3.11 in default runtimes.