-
Notifications
You must be signed in to change notification settings - Fork 67
Idea editor sample #1030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idea editor sample #1030
Conversation
|
Skipping CI for Draft Pull Request. |
amisevsk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested sample in an OpenShift 4.12 cluster, and it works as expected (with a few caveats):
- Setting
.spec.routingClass: che(with Eclipse Che installed in the cluster) results in the workspace working as expected - Using the
basicrouting class (default) results in the workspace failing to start. This is due to #1031 and not a problem with this PR; using the correct URL allows accessing the editor as expected.
In my testing, the experience of actually using the editor is fairly slow, with typing into a file taking multiple seconds at times, though I think this is an issue with the editor/setup and not the devfile itself.
Codecov ReportBase: 50.17% // Head: 50.25% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1030 +/- ##
==========================================
+ Coverage 50.17% 50.25% +0.08%
==========================================
Files 70 70
Lines 6021 6031 +10
==========================================
+ Hits 3021 3031 +10
+ Misses 2770 2769 -1
- Partials 230 231 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
I'm not sure whether it make any sense to have a sample command here as the IDEA knows nothing about devfile-based commands. |
That's a good point -- IDEA would need some sort of plugin or similar to understand devfile commands. They should likely be dropped for now. |
AObuchow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been trying to test this on OpenShift 4.12, but unfortunately the workspace hasn't been able to start up before the timeout yet after 3 tries.
Asides from minor comment, the actual DevWorkspace YAML looks good to me.
I recommend squashing all the commits for this PR into one once it is ready for a final review/merge.
Just realized I forgot to try this PR with #1032 applied 😅 will re-test |
AObuchow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amisevsk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from the project name
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, AObuchow, vitaliy-guliy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Before we can merge, commits should be squashed as appropriate and all need a signed-off-by footer. |
|
New changes are detected. LGTM label has been removed. |
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
eb0f601 to
45e5e0b
Compare
What does this PR do?
Adds a sample with JetBrains IDEA editor
What issues does this PR fix or reference?
Is it tested? How?
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che