Fix endpoints handling

[amisevsk]

What does this PR do?

Improves how the basic routing solver handles endpoints that define paths/queries/fragments.

What issues does this PR fix or reference?

Closes #1031

Is it tested? How?

Tests are updated. To test directly, apply the following workspace and test that resolved endpoints in the DevWorkspaceRouting match what is expected on OpenShift and Kubernetes:

kind: DevWorkspace
apiVersion: workspace.devfile.io/v1alpha2
metadata:
  name: plain-devworkspace
spec:
  started: true
  routingClass: 'basic'
  template:
    components:
      - name: web-terminal
        container:
          image: quay.io/wto/web-terminal-tooling:next
          memoryLimit: 512Mi
          mountSources: true
          command:
            - "tail"
            - "-f"
            - "/dev/null"
          endpoints:
            - name: test-query
              attributes:
                type: main
              targetPort: 8888
              exposure: public
              path: /?test-param
              protocol: http
            - name: test-path-query
              targetPort: 8889
              exposure: public
              path: /test/path/?test-param
              protocol: http
            - name: test-path
              targetPort: 8890
              exposure: public
              path: /test/path/
              protocol: http
            - name: test-no-path
              targetPort: 8891
              exposure: public
              protocol: http

PR Checklist

• E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
  • v8-devworkspace-operator-e2e: DevWorkspace e2e test
  • v8-che-happy-path: Happy path for verification integration with Che

[codecov]

Codecov Report

Base: 50.17% // Head: 50.20% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (26f78bb) compared to base (27b6c98).
Patch coverage: 82.35% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1032      +/-   ##
==========================================
+ Coverage   50.17%   50.20%   +0.03%     
==========================================
  Files          70       70              
  Lines        6021     6031      +10     
==========================================
+ Hits         3021     3028       +7     
- Misses       2770     2773       +3     
  Partials      230      230              

Impacted Files	Coverage Δ
...r/devworkspacerouting/solvers/resolve_endpoints.go	33.33% <82.35%> (+5.91%)	⬆️
controllers/workspace/devworkspace_controller.go	61.58% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[AObuchow]

Code looks good to me.

Tested on OpenShift 4.12 and checked the status of the DWR object on the cluster and things seemed correct:

apiVersion: controller.devfile.io/v1alpha1
kind: DevWorkspaceRouting
(...)
spec:
  devworkspaceId: workspacee5084d468fca49bb
  endpoints:
    web-terminal:
      - attributes:
          type: main
        exposure: public
        name: test-query
        path: /?test-param
        protocol: http
        targetPort: 8888
      - exposure: public
        name: test-path-query
        path: /test/path/?test-param
        protocol: http
        targetPort: 8889
      - exposure: public
        name: test-path
        path: /test/path/
        protocol: http
        targetPort: 8890
      - exposure: public
        name: test-no-path
        protocol: http
        targetPort: 8891
  podSelector:
    controller.devfile.io/devworkspace_id: workspacee5084d468fca49bb
  routingClass: basic
status:
  exposedEndpoints:
    web-terminal:
      - attributes:
          type: main
        name: test-query
        url: >-
          http://workspacee5084d468fca49bb.apps.ci-ln-vj4kpzb-72292.origin-ci-int-gce.dev.rhcloud.com/test-query/?test-param
      - name: test-path-query
        url: >-
          http://workspacee5084d468fca49bb.apps.ci-ln-vj4kpzb-72292.origin-ci-int-gce.dev.rhcloud.com/test-path-query/test/path/?test-param
      - name: test-path
        url: >-
          http://workspacee5084d468fca49bb.apps.ci-ln-vj4kpzb-72292.origin-ci-int-gce.dev.rhcloud.com/test-path/test/path/
      - name: test-no-path
        url: >-
          http://workspacee5084d468fca49bb.apps.ci-ln-vj4kpzb-72292.origin-ci-int-gce.dev.rhcloud.com/test-no-path/
  message: DevWorkspaceRouting prepared
  phase: Ready

[AObuchow]

Not sure if this commented out code was intentional or not?

[amisevsk]

Nope, left-over from refactoring

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amisevsk, AObuchow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [amisevsk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

New changes are detected. LGTM label has been removed.