Skip to content

Conversation

@johnmcollier
Copy link
Member

Cleans up the OWNERS file to represent the current reviewers and approvers for the repo

Clean up OWNERS file
@openshift-ci
Copy link

openshift-ci bot commented Sep 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be blocked by #99: #99 (comment)

Other than DCO everything else looks good.

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should include @feloy and @rm3l

@johnmcollier
Copy link
Member Author

@michael-valdron Updated.

I can override the failing checks as this is just modifying the OWNERS file and no code.

@michael-valdron
Copy link
Member

/retest

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to revise to only include primary and secondary devfile team members.

@michael-valdron
Copy link
Member

#101 made the same changes, I think we can close this PR now.

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@michael-valdron
Copy link
Member

#101 made the same changes, I think we can close this PR now.

Closing this PR now..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants